fix: restore mTLS auth with client cert#2171
Open
maxim-sermin wants to merge 2 commits intohuggingface:mainfrom
Open
fix: restore mTLS auth with client cert#2171maxim-sermin wants to merge 2 commits intohuggingface:mainfrom
maxim-sermin wants to merge 2 commits intohuggingface:mainfrom
Conversation
maxim-sermin
force-pushed
the
fix/restore-mtls
branch
from
d98ce1e to
816360b
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 816360b8ee
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The ability to attach a client certificate to authenticate with mTLS was removed with this commit a while back.
Still, the documentation states that mTLS is supported. This is actually quite a unique functionality among chat clients and lead me to using this project in the first place.
Changes
USE_CLIENT_CERTIFICATE,CERT_PATH,KEY_PATH) were still there - unchangedsrc/lib/utils/loadClientCerts.tswhich callssetGlobalDispatcherloadClientCertificatesinsrc/lib/server/models.tsbecause this was the first usage for me - open for suggestions for better location